Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.1 #148

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AkihiroSuda
Copy link
Member

  • github.com/containerd/containerd/{containers,images,...} -> github.com/containerd/containerd/v2/core/{containers,images,...}
  • github.com/containerd/containerd/{errdefs,logs,platforms} -> github.com/containerd/{errdefs,logs,platforms}
  • github.com/containerd/typeurl -> github.com/containerd/typeurl/v2
  • github.com/urfave/cli -> github.com/urfave/cli/v2 (See Migrate Urfave CLI from v1 to v2 containerd#9809)

@AkihiroSuda
Copy link
Member Author

--- FAIL: TestInit (0.00s)
    payload_test.go:28: failed to detect gogo: false
FAIL
FAIL	github.com/containerd/imgcrypt/images/encryption	0.006s

https://github.com/containerd/imgcrypt/actions/runs/8448335008/job/23140237920?pr=148

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this file, but not sure if this is correct

@AkihiroSuda

This comment was marked as resolved.

@AkihiroSuda AkihiroSuda force-pushed the containerd-v2 branch 4 times, most recently from f22bad5 to 5daba92 Compare March 27, 2024 14:26
@AkihiroSuda
Copy link
Member Author

Testing creation of container from encrypted image
Encrypting docker.io/library/bash:latest to docker.io/library/bash:enc
ctr: content digest sha256:4f02cf678855fbab38b3638a131fb83cbbea5e1f815dce93c2d8a9d12796e541: not found
Error: Image encryption with JWE failed; public key: jwe:/tmp/tmp.HZ76rjzgUp/mypubkey.jwk

https://github.com/containerd/imgcrypt/actions/runs/8453433526/job/23156116537?pr=148

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
- github.com/containerd/containerd/{containers,images,...} -> github.com/containerd/containerd/v2/core/{containers,images,...}
- github.com/containerd/containerd/{errdefs,logs,platforms} -> github.com/containerd/{errdefs,logs,platforms}
- github.com/containerd/typeurl -> github.com/containerd/typeurl/v2
- github.com/urfave/cli -> github.com/urfave/cli/v2 (See containerd/containerd PR 9809)
- github.com/gogo/protobuf -> github.com/containerd/containerd/v2/protobuf

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.0 go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.1 Apr 25, 2024
@yylt
Copy link

yylt commented May 13, 2024

the failed about CI test may related to the #69

@yylt
Copy link

yylt commented May 13, 2024

/cc @stefanberger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants