Remove references to io/ioutil package #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
remove-ioutil
branch
from
30779b5
to
47af5e9
Compare
AkihiroSuda
reviewed
Nov 10, 2022
austinvazquez
force-pushed
the
remove-ioutil
branch
from
47af5e9
to
b198e8b
Compare
Package io/ioutil has been marked deprecated in Go 1.16. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
remove-ioutil
branch
3 times, most recently
from
ebe8038
to
85dd95c
Compare
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
remove-ioutil
branch
from
85dd95c
to
12b5c42
Compare
austinvazquez
commented
Feb 22, 2023
Comment on lines
+186
to
+188
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get snapshot %s from storage: %w", key, err) | ||
| } |
There was a problem hiding this comment.
Resolves ineffectual assignment of err. If storage.GetSnapshot call fails then s == snapshots.Snapshot{} or empty snapshot struct. From my read it made sense to propagate the error here instead of continuing and attempting to mount an empty snapshot. Lmk your thoughts.
austinvazquez
commented
Feb 22, 2023
| @@ -182,9 +181,12 @@ func (o *snapshotter) Mounts(ctx context.Context, key string) ([]mount.Mount, er | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| defer t.Rollback() | |||
There was a problem hiding this comment.
Moved just for readability / matches the standard practice of other functions in this snapshotter.
|
@AkihiroSuda, I removed some not required changes if you would take a second look. Enabling errcheck could probably be its own PR as most of its warnings are around checking of rollback errors on non-writable transactions which is unlikely to fail. |
AkihiroSuda
reviewed
Nov 1, 2023
| env: | ||
| GO111MODULE: on | ||
| GO_VERSION: 1.20.x |
AkihiroSuda
reviewed
Nov 1, 2023
| @@ -5,6 +5,10 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
|
|
|||
| env: | |||
| GO_VERSION: 1.20.x | |||
|
Sorry, overlooked this, needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package io/ioutil has been marked deprecated in Go 1.16.
Signed-off-by: Austin Vazquez macedonv@amazon.com