Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move cmd/continuity to its own go module #200

Merged
merged 5 commits into from Apr 4, 2022
Merged

move cmd/continuity to its own go module #200

merged 5 commits into from Apr 4, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 1, 2022 •
edited

this command-line is mostly used for testing and debugging, and its
dependencies should not be a dependency of the main module (library)

@thaJeztah
Copy link
Member Author

after this, we should consider removing the vendor directory as the main module is then a library

@thaJeztah

This comment was marked as outdated.

Sign in to view
@thaJeztah thaJeztah force-pushed the separate_cli branch 5 times, most recently from d824335 to dc3b390 Compare April 1, 2022 21:54
@thaJeztah
Copy link
Member Author

I'll do a rebase (#198 was merged)

@thaJeztah
go.mod: update logrus to v1.8.1
840357f 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
move commands -> cmd/continuity/commands
071eff3 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
move continuityfs -> cmd/continuity/continuityfs
480f3bb 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
remove version package
5b38337 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
move cmd/continuity to its own go module
9d49199 
this command-line is mostly used for testing and debugging, and its
dependencies should not be a dependency of the main module (library)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

rebased 👍 @kzys @dmcgowan PTAL if this LGTY

estesp
estesp approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 57be3d2 into containerd:main Apr 4, 2022
This was referenced Apr 4, 2022
Closed
Closed
@thaJeztah thaJeztah deleted the separate_cli branch April 4, 2022 16:20
@thaJeztah thaJeztah mentioned this pull request Jul 14, 2022
Closed
@dmcgowan dmcgowan mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thaJeztah @kzys @dmcgowan @estesp @AkihiroSuda