Fix wrapping errors #196
Merged
Fix wrapping errors #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
dmcgowan
approved these changes
Mar 25, 2022
tonistiigi
reviewed
Mar 26, 2022
| @@ -158,7 +158,9 @@ func copyDirectory(dst, src string, inodes map[uint64]string, o *copyDirOpts) er | |||
| } | |||
| default: | |||
| // TODO: Support pipes and sockets | |||
| return fmt.Errorf("unsupported mode %s: %w", fi.Mode(), err) | |||
| if err != nil { | |||
There was a problem hiding this comment.
I don't see how this can ever be non-nil.
| return fmt.Errorf("unsupported mode %s: %w", fi.Mode(), err) | ||
| if err != nil { | ||
| return fmt.Errorf("unsupported mode %s: %w", fi.Mode(), err) | ||
| } |
There was a problem hiding this comment.
This does not fix #185 (comment) . It will just skip over this condition until it reaches copyFileInfo and errors there because the path does not exist.
There was a problem hiding this comment.
covered in:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt.Errorf: use %w, not %v to wrap errorsfs: fix wrapping nil errFollow-up to: