Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/golang/protobuf v1.3.5 #158

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 17, 2020

Follow-up to #157; only the last commit (92bffbb) is new. This version matches what's used in containerd and buildkit, and Cobra 1.0 depends on protobuf > v1.3.1

Keeping this separate, as it may have to be reviewed separately

@thaJeztah
Copy link
Member Author

this one should also be ready for review @estesp @dmcgowan (sorry for the multiple PR's, trying to somewhat keep changes reviewable)

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

@AkihiroSuda @dmcgowan ptal

1 similar comment
@thaJeztah
Copy link
Member Author

@AkihiroSuda @dmcgowan ptal

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@AkihiroSuda AkihiroSuda merged commit 968621f into containerd:master Mar 13, 2021
@thaJeztah thaJeztah deleted the update_protobuf branch March 13, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants