Return correct error if CRIU binary is missing #9960
Conversation
For the first version of containerd's "Forensic Container Checkpointing" support the error message if the CRIU binary is not found was deliberately wrong to not break Kubernetes e2e_node tests. Now that the e2e_node tests have been adapted, containerd can return the correct error message. Signed-off-by: Adrian Reber <areber@redhat.com>
|
Hi @adrianreber. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
Changed to a draft PR as long the necessary Kubernetes PR is not merged. |
|
With the corresponding Kubernetes changes merged this can now also be reviewed. Switching from draft to ready for review. |
| log.G(ctx).WithError(err).Errorf("Failed to checkpoint container %q", r.GetContainerId()) | ||
| return nil, status.Errorf(codes.Unimplemented, "method CheckpointContainer not implemented") | ||
| errorMessage := fmt.Sprintf( | ||
| "CRIU binary not found or too old (<%d). Failed to checkpoint container %q", |
There was a problem hiding this comment.
suggestion:
errMsg := fmt.Sprintf("failed to checkpoint container %q", r.GetContainerId())
since the detail message is covered by err.
There was a problem hiding this comment.
Unfortunately Kubernetes depends on the error message. Changing it now requires Kubernetes changes again.
There was a problem hiding this comment.
For the first version of containerd's "Forensic Container Checkpointing" support the error message if the CRIU binary is not found was deliberately wrong to not break Kubernetes e2e_node tests.
Now that the e2e_node tests have been adapted, containerd can return the correct error message.
Depends on kubernetes/kubernetes#123886