sandbox: update sandbox resource before/after task creation/deletion #9904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @abel-von. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
abel-von
changed the title
abel-von
force-pushed
the
sandbox-task-0301
branch
4 times, most recently
from
b8115cd
to
4dc8e31
Compare
Signed-off-by: Abel Feng <fshb1988@gmail.com>
there are two kinds of task, shimTask and sandboxedTask, shimTask is the legacy implementation and compatible with the podsandbox, the sandboxedTask is the task running in the sandbox created by sandbox sontroller v2 Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
abel-von
force-pushed
the
sandbox-task-0301
branch
from
4dc8e31
to
7fa479a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sandboxed Task, we call the task api directly into the sandbox. For some kind of sandbox, we may have to update the resources of the sandbox before/after task creation or deletion, and it has to be done outside the sandbox, so we rely on the sandbox controller to update the resources of the sandbox.