Add CRI Service plugin type #9681
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
dmcgowan
force-pushed
the
cri-runtime-plugin
branch
3 times, most recently
from
bc20433
to
1363b12
Compare
|
/test all |
| @@ -25,13 +26,13 @@ import ( | |||
| "github.com/containerd/plugin/registry" | |||
|
|
|||
| containerd "github.com/containerd/containerd/v2/client" | |||
| srvconfig "github.com/containerd/containerd/v2/cmd/containerd/server/config" | |||
There was a problem hiding this comment.
this felt a tad wrong ... importing from cmd/containerd into here. but we have done this elsewhere so it's ok.
There was a problem hiding this comment.
We can probably safely move that config package out from there. It got moved as a subpackage but considering it is our main configuration object, it could find a better home.
There was a problem hiding this comment.
I'll move the configuration version out into the version package in a follow up. That's only thing I saw being imported from config
dmcgowan
force-pushed
the
cri-runtime-plugin
branch
from
1363b12
to
d4ac631
Compare
|
Thanks @henry118 , updated |
dmcgowan
force-pushed
the
cri-runtime-plugin
branch
3 times, most recently
from
592477c
to
74ba19f
Compare
Create new plugin type for CRI runtime and image services. Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
cri-runtime-plugin
branch
from
74ba19f
to
fecb216
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dmcgowan
force-pushed
the
cri-runtime-plugin
branch
2 times, most recently
from
c8c0794
to
5816c89
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
cri-runtime-plugin
branch
from
5816c89
to
64b4778
Compare
|
This seems a huge breaking change |
Now that the CRI image configuration is split out from the runtime configuration, there is no need to enforce plugin order between the images and runtime. Without the need for order, they can be more cleanly organized as a runtime and images plugins both of type CRI Image Service. This is a cleaner alternative to the CRI base plugin, which (mis)used the internal plugin type only to hold configuration.