[release/1.6] support fetching containerd from non public GCS buckets #8657
Conversation
- add support to fetch and download containerd tarball from GCS buckets that require authentication. GCS_BUCKET_TOKEN should have read access to the bucket from which artifacts are to be fetched. The token is expected to be present in the instance metadata of the VM, similar to other node environment variables Signed-off-by: Akhil Mohan <makhil@vmware.com> (cherry picked from commit 9df96dc) Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <makhil@vmware.com> (cherry picked from commit b94c101) Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
|
Hi @akhilerm. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can I get an |
|
/ok-to-test |
|
/hold |
|
/retest |
cherry pick #7771 (not clean)
add support to fetch and download containerd tarball from GCS buckets that require authentication.
GCS_BUCKET_TOKEN should have read access to the bucket from which artifacts are to be fetched. The token is expected to be present in the instance metadata of the VM, similar to other node environment variables
To use this in tests from kubernetes, a new node env can be added as follows here. <your_gcs_bucket_token> can be fetched from a secret or from an env.
Notes for reviewer:
The backport of these changes were tried in #7823, but caused CI failure in kubernetes test jobs and was hence immediately reverted in #7830. Raising this PR to figure out what caused the test failures and debug it.