Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kube v1.26: remove v1alph2 cri support #7863

Merged
merged 1 commit into from Dec 28, 2022

Conversation

pacoxu
Copy link
Contributor

@pacoxu pacoxu commented Dec 23, 2022

According to kubernetes/kubernetes#110618, v1.26 removed cri v1alpha2 support

@k8s-ci-robot
Copy link

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu pacoxu force-pushed the v1.26-kube branch 2 times, most recently from 7d9d12a to 6ffbb30 Compare December 23, 2022 03:56
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments and suggested changes

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
@pacoxu pacoxu force-pushed the v1.26-kube branch 2 times, most recently from 39556bd to 77e4f1c Compare December 26, 2022 02:34
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

RELEASES.md Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda added kind/docs area/cri Container Runtime Interface (CRI) labels Dec 27, 2022
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cri Container Runtime Interface (CRI) kind/docs needs-ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants