-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump several go.mod libs. #7857
Conversation
Hi @yanggangtony. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR! go.sum file in integration/client directory doesn't match the file in the root directory. You can fix this by running |
@fangn2 |
@@ -102,6 +103,7 @@ require ( | |||
github.com/google/gofuzz v1.2.0 // indirect | |||
github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0 // indirect | |||
github.com/hashicorp/errwrap v1.1.0 // indirect | |||
github.com/josephspurrier/goversioninfo v1.4.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the use of a tools.go
file now causes all the tools used in go-winio to be imported; I see tools/mkwinsyscall
, github.com/akavel/rsrc
, as well as the other tools used in that repo 😞
I tried to look if we could get rid of those (see microsoft/go-winio#266, https://github.com/microsoft/hcsshim/blob/0b8319a721ceef568157c20e5b75db88a9f6570c/tools.go#L3-L6), but it looks like there's even more things than I thought were added as dependency because of that
Perhaps that tools
should be a separate module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, you means to reduce the "github.com/josephspurrier/goversioninfo" import?
Would you have any ideas about that.
It is imported by 'go mod tidy':sweat_smile::sweat_smile:
Signed-off-by: yanggang <gang.yang@daocloud.io>
There's another PR open to pull in the same hcsshim tag #7810. I'd say lets leave that off here as we figure out the issue @thaJeztah is mentioning |
Ah, thanks for linking that one; let me know if you need brainstorming @dcantah |
Outdated, suggest bumping individually or when the changes are dependent on each other. |
Signed-off-by: yanggang gang.yang@daocloud.io
Bump hcsshim , go-systemd , go-restful , otel go.mods..