Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump several go.mod libs. #7857

Closed
wants to merge 1 commit into from
Closed

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

Bump hcsshim , go-systemd , go-restful , otel go.mods..

@k8s-ci-robot
Copy link

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fangn2
Copy link
Contributor

fangn2 commented Dec 22, 2022

Thanks for the PR!

go.sum file in integration/client directory doesn't match the file in the root directory.

You can fix this by running go mod tidy in the integration/client directory.

@yanggangtony
Copy link
Contributor Author

@fangn2
Oh, maybe i first go mod tidy , then update again , and forget go mod tidy it.....
:bowtie: :bowtie:
thanks for the review..
Had updated.

@@ -102,6 +103,7 @@ require (
github.com/google/gofuzz v1.2.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/josephspurrier/goversioninfo v1.4.0 // indirect
Copy link
Member

@thaJeztah thaJeztah Dec 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the use of a tools.go file now causes all the tools used in go-winio to be imported; I see tools/mkwinsyscall, github.com/akavel/rsrc , as well as the other tools used in that repo 😞

I tried to look if we could get rid of those (see microsoft/go-winio#266, https://github.com/microsoft/hcsshim/blob/0b8319a721ceef568157c20e5b75db88a9f6570c/tools.go#L3-L6), but it looks like there's even more things than I thought were added as dependency because of that

Perhaps that tools should be a separate module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you means to reduce the "github.com/josephspurrier/goversioninfo" import?
Would you have any ideas about that.
It is imported by 'go mod tidy':sweat_smile::sweat_smile:

Signed-off-by: yanggang <gang.yang@daocloud.io>
@dcantah
Copy link
Member

dcantah commented Dec 26, 2022

There's another PR open to pull in the same hcsshim tag #7810. I'd say lets leave that off here as we figure out the issue @thaJeztah is mentioning

@thaJeztah
Copy link
Member

There's another PR open to pull in the same hcsshim tag #7810. I'd say lets leave that off here as we figure out the issue @thaJeztah is mentioning

Ah, thanks for linking that one; let me know if you need brainstorming @dcantah

@dmcgowan
Copy link
Member

Outdated, suggest bumping individually or when the changes are dependent on each other.

@dmcgowan dmcgowan closed this Aug 24, 2023
@yanggangtony yanggangtony deleted the go-mod branch August 29, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants