Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] fix: support simultaneous create diff for same parent snapshot #7756

Merged
merged 1 commit into from Dec 6, 2022

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Dec 5, 2022

Cherry-pick into 1.6:

This makes it possible to run rootfs.CreateDiff multiple times simultaneously.

Original PR message:
"""
In CreateDiff function, we wil create view snapshot base on parent snapshot,
view snapshot name is "<parent snapshot KEY>-parent-view",

so while, It does not support concurrent operations,other user will be return to the error that the snapshot already exists.

So, we add uniquePart() as a suffix.
"""

(cherry picked from commit 344431c)
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

Signed-off-by: Qian Zhang <cosmoer@qq.com>
(cherry picked from commit 344431c)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@k8s-ci-robot
Copy link

Hi @vvoland. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid fuweid merged commit 864cce9 into containerd:release/1.6 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants