Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsnotify bump and change code #7703

Merged
merged 2 commits into from Nov 20, 2022
Merged

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

This pr have done 2 things.
(1) Bump fsnotify version to 1.6.0
fsnotify new feature and fsnotify 1.6.0 release .
Maybe we can change our code follow the style.

(2)Change the bit logic for fsnotify.
I test code in my local env , like that.
image

yanggang added 2 commits November 20, 2022 09:37
Signed-off-by: yanggang <gang.yang@daocloud.io>
Signed-off-by: yanggang <gang.yang@daocloud.io>
@k8s-ci-robot
Copy link

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanggangtony yanggangtony changed the title Fsnotify Fsnotify bump and change code Nov 20, 2022
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@AkihiroSuda AkihiroSuda merged commit b9f79d3 into containerd:main Nov 20, 2022
@yanggangtony yanggangtony deleted the fsnotify branch November 25, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants