Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes v1.25 supported version as v1.24 #7326

Merged
merged 1 commit into from Aug 31, 2022

Conversation

pacoxu
Copy link
Contributor

@pacoxu pacoxu commented Aug 26, 2022

https://github.com/kubernetes/kubernetes/releases/v1.25.0

There seems to be no containerd related change

CRI changes are like below(v1.25 with v1.24):

containerd v1.6.8 is using cri-api v0.23.1 that is same as containerd v1.6.4

@k8s-ci-robot
Copy link

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kzys
Copy link
Member

kzys commented Aug 26, 2022

/ok-to-test

@thaJeztah
Copy link
Member

If updates are needed in the Pr; could you fix the typo in the commit message (kuberentes -> kubernetes)? In case we need to find back the commit, makes it easier 😁

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu
Copy link
Contributor Author

pacoxu commented Aug 27, 2022

If updates are needed in the Pr; could you fix the typo in the commit message (kuberentes -> kubernetes)? In case we need to find back the commit, makes it easier 😁

Updated. Sorry for the typo.

@thaJeztah
Copy link
Member

No worries at all; thank you!

(It was a really minor issue, but experience taught me that a silly typo can make you spend some time scratching your head "where was that commit?")

Oh! Could you also edit the title on GitHub (looks like I don't have permissions to do so 😓)

@pacoxu pacoxu changed the title Add kuberentes v1.25 supported version as v1.24 Add kubernetes v1.25 supported version as v1.24 Aug 27, 2022
@pacoxu
Copy link
Contributor Author

pacoxu commented Aug 27, 2022

title was updated now. Thanks.

Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@samuelkarp samuelkarp merged commit f634868 into containerd:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants