Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6 backport] oci: WithDefaultUnixDevices(): remove tun/tap from the default devices #7268

Merged
merged 1 commit into from Aug 8, 2022

Commits on Aug 8, 2022

  1. oci: WithDefaultUnixDevices(): remove tun/tap from the default devices

    A container should not have access to tun/tap device, unless it is explicitly
    specified in configuration.
    
    This device was already removed from docker's default, and runc's default;
    
    - opencontainers/runc@2ce40b6
    - https://github.com/moby/moby//commit/9c4570a958df42d1ad19364b1a8da55b891d850a
    
    Per the commit message in runc, this should also fix these messages;
    
    > Apr 26 03:46:56 foo.bar systemd[1]: Couldn't stat device /dev/char/10:200: No such file or directory
    
    coming from systemd on every container start, when the systemd cgroup driver
    is used, and the system runs an old (< v240) version of systemd
    (the message was presumably eliminated by [1]).
    
    [1]: systemd/systemd@d5aecba
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit a3ac156)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Aug 8, 2022
    Copy the full SHA
    ed9d3dc View commit details
    Browse the repository at this point in the history