New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: github.com/urfave/cli v1.22.9 and fix "verify-vendor" script #6997
Conversation
I'll work on a follow-up to this one to see if we can make use of the new |
Hmm... what's this error?
|
Before this patch, if the go.mod did not contain a replace rule, jq would fail (Cannot iterate over null), and Bash would produce an error when trying to add an empty `$key` to `map_requires`: make verify-vendor + verify-vendor jq: error (at <stdin>:581): Cannot iterate over null (null) /go/src/github.com/containerd/containerd//script/verify-go-modules.sh: line 44: map_replaces_1[$key]: bad array subscript make: *** [Makefile:435: verify-vendor] Error 1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The regression in v1.22.2 has been resolved, so we can drop the replace rule and use the latest v1.22.x version. full diff: urfave/cli@v1.22.1...v1.22.9 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Pushed a commit to fix the vendor check |
Failures should probably not be related (as #6998 went green); let me close/reopen to trigger CI |
Hmm.. that didn't seem to trigger the cirrus jobs (which were the ones failing); perhaps it's just slow to report, so let's see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 (nice to see the replace rules disappearing!)
fix verify-vendor if go.mod does not contain replace rules
Before this patch, if the go.mod did not contain a replace rule, jq would fail
(Cannot iterate over null), and Bash would produce an error when trying to add
an empty
$key
tomap_requires
:vendor: github.com/urfave/cli v1.22.9
The regression in v1.22.2 has been resolved, so we can drop the
replace rule and use the latest v1.22.x version.
full diff: urfave/cli@v1.22.1...v1.22.9