[release/1.5 backport] GHA fixes, update GolangCI-Lint v1.42.0, and go-mdman v2.0.1 #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: cpuguy83/go-md2man@v2.0.0...v2.0.1 - Fix handling multiple definition descriptions - Fix inline markup causing table cells to split - Remove escaping tilde character (prevents tildes (`~`) from disappearing). - Do not escape dash, underscore, and ampersand (prevents ampersands (`&`) from disappearing). - Ignore unknown HTML tags to prevent noisy warnings Note that this only updates the binaries we install. The vendor code also includes go-md2man (as indirect dependency of urfave/cli). I don't think we use that feature, so I did not add it to our go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d2b6d19) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
For some reason the Linux CI runs end up using go 1.15.14 instead of 1.16.6 for the Windows runs, or any of the other CI steps. Not sure if this is due to the linter installing it's own version of go or something else. Signed-off-by: Daniel Canter <dcanter@microsoft.com> (cherry picked from commit 534685f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
golint has been deprecated and replaced by revive since v1.41.0. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> (cherry picked from commit 4dd5ca7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Relates to #6509 (comment) |
dmcgowan
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of: