Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.5] cherry-pick: cri: add devices for privileged container #5981

Merged
merged 1 commit into from Sep 20, 2021
Merged

[release/1.5] cherry-pick: cri: add devices for privileged container #5981

merged 1 commit into from Sep 20, 2021
+3 −7

Conversation

scuzhanglei
Copy link
Contributor

Cherry-pick PR #5939 from main to release/1.5

@k8s-ci-robot
Copy link

Hi @scuzhanglei. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 13, 2021

Build succeeded.

@scuzhanglei
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link

@scuzhanglei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scuzhanglei
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

@scuzhanglei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 15, 2021

Build succeeded.

@estesp
Copy link
Member

estesp commented Sep 15, 2021

You need to rebase on the head of release/1.5 to pick up the change in test image reference required for tests to pass. Thanks!

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 16, 2021

Build succeeded.

@scuzhanglei
Copy link
Contributor Author

still failed.

@dcantah dcantah mentioned this pull request Sep 17, 2021
Closed
@scuzhanglei
cri: add devices for privileged container
514137a 
Signed-off-by: zhanglei <zhanglei@smartx.com>
(cherry picked from commit 756f4a3)
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 18, 2021

Build succeeded.

fuweid
fuweid approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 3f4f6bc into containerd:release/1.5 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scuzhanglei @k8s-ci-robot @estesp @AkihiroSuda @fuweid