New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.5] Backport go.mod: Update hcsshim to v0.8.21 #5942
[release/1.5] Backport go.mod: Update hcsshim to v0.8.21 #5942
Conversation
This version brings in some bug fixes to layer handling. The actual fix isn't present in the diff as it's not used here, but the Windows shim is built from the tag present in go.mod, so the fix will be in the Windows shim on a new release of Containerd if this tag is in. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@estesp You've got some faith approving before the CI finishes! 😝 |
fyi @kevpar @jsturtevant again |
well, it's Windows.. I have faith you all know what you're doing (and what you're fixing) as I got rid of my Windows set up last year 😂 |
@estesp Fair enough! hahah |
Build succeeded.
|
I swear I've seen the CGroupsV2 tests fail more than they pass 😔 or maybe they have a grudge against me |
This version brings in some bug fixes to layer handling. The actual fix isn't
present in the diff as it's not used here, but the Windows shim is built from
the tag present in go.mod, so the fix will be in the Windows shim on a new release
of Containerd if this tag is in.
Signed-off-by: Daniel Canter dcanter@microsoft.com