Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.5] Backport go.mod: Update hcsshim to v0.8.21 #5942

Merged
merged 1 commit into from Sep 8, 2021

Conversation

dcantah
Copy link
Member

@dcantah dcantah commented Sep 3, 2021

This version brings in some bug fixes to layer handling. The actual fix isn't
present in the diff as it's not used here, but the Windows shim is built from
the tag present in go.mod, so the fix will be in the Windows shim on a new release
of Containerd if this tag is in.

Signed-off-by: Daniel Canter dcanter@microsoft.com

This version brings in some bug fixes to layer handling. The actual fix isn't
present in the diff as it's not used here, but the Windows shim is built from
the tag present in go.mod, so the fix will be in the Windows shim on a new release
of Containerd if this tag is in.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@k8s-ci-robot
Copy link

Hi @dcantah. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcantah
Copy link
Member Author

dcantah commented Sep 3, 2021

@estesp You've got some faith approving before the CI finishes! 😝

@dcantah
Copy link
Member Author

dcantah commented Sep 3, 2021

fyi @kevpar @jsturtevant again

@estesp
Copy link
Member

estesp commented Sep 3, 2021

@estesp You've got some faith approving before the CI finishes! 😝

well, it's Windows.. I have faith you all know what you're doing (and what you're fixing) as I got rid of my Windows set up last year 😂

@dcantah
Copy link
Member Author

dcantah commented Sep 3, 2021

@estesp Fair enough! hahah

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 3, 2021

Build succeeded.

@dcantah
Copy link
Member Author

dcantah commented Sep 3, 2021

I swear I've seen the CGroupsV2 tests fail more than they pass 😔 or maybe they have a grudge against me

@dcantah dcantah changed the title [release/1.5] go.mod: Update hcsshim to v0.8.21 [release/1.5] Backport go.mod: Update hcsshim to v0.8.21 Sep 7, 2021
@AkihiroSuda AkihiroSuda merged commit f40ee07 into containerd:release/1.5 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants