Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.5 backport] install apparmor parser for arm64, and update seccomp to 2.5.1 #5763

Merged
merged 2 commits into from Aug 16, 2021
Merged

[release/1.5 backport] install apparmor parser for arm64, and update seccomp to 2.5.1 #5763

merged 2 commits into from Aug 16, 2021

Conversation

thaJeztah
Copy link
Member

backport of:

resolves #5444 for the 1.5 branch

mikebrow and others added 2 commits July 20, 2021 16:29
@mikebrow @thaJeztah
update seccomp version
0bc1e1d 
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
(cherry picked from commit b56527c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@dims @thaJeztah
Install apparmor parser for arm64 environment
eb4ba99 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
(cherry picked from commit a93b5cb)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@dims @mikebrow let me know if you want the first commit (seccomp) as well, otherwise I'll drop the commit and resolve the conflict instead

@dims
Copy link
Member

dims commented Jul 20, 2021

i don't mind it.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 20, 2021

Build succeeded.

@dmcgowan dmcgowan added this to Needs Discussion in Code Review Jul 23, 2021
estesp
estesp approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan moved this from Needs Discussion to Merge on Green in Code Review Aug 11, 2021
@dmcgowan dmcgowan merged commit 25ad944 into containerd:release/1.5 Aug 16, 2021
Code Review automation moved this from Merge on Green to Done Aug 16, 2021
@thaJeztah thaJeztah deleted the 1.5_backport_install_apparmor_parser_for_arm64_env branch August 16, 2021 23:08
@bxy4543 bxy4543 mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

@mikebrow mikebrow

Labels
None yet
Projects
Code Review
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@thaJeztah @dims @kzys @dmcgowan @samuelkarp @estesp @mikebrow