Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update urfave/cli v1.22.1, go-md2man v2.0.0, blackfriday v2.0.1 #4239

Merged
merged 1 commit into from Jul 2, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 8, 2020

This updates urfave/cli and its dependencies to v1.22.1:

Also adds github.com/shurcooL/sanitized_anchor_name as a new dependency, which is
used by russross/blackfriday, but will be removed again in a future update (dependency
is already removed on the v2 branch through russross/blackfriday@919b1f5

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2020

Build succeeded.

vendor.conf Outdated
github.com/sirupsen/logrus 60c74ad9be0d874af0ab0daef6ab07c5c5911f0d # v1.6.0
github.com/syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
github.com/urfave/cli bfe2e925cfb6d44b40ad3a779165ea7e8aff9212 # v1.22.0
github.com/urfave/cli 053ba9dd02d2bfb768da2c1c50370c59d41dc04b # v1.22.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get somebody to fix urfave/cli#1092

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, dang. I read that issue, but forgot about it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was trying to get the other dependencies updated to the v2 variants to be in line with moby and docker cli 😅

@thaJeztah thaJeztah marked this pull request as draft May 8, 2020 12:39
@thaJeztah
Copy link
Member Author

moving to "draft", pending urfave/cli#1092 to be merged and released

@AkihiroSuda
Copy link
Member

The pending PR: urfave/cli#1135

@thaJeztah thaJeztah changed the title update urfave/cli v1.22.4, go-md2man v2.0.0, blackfriday v2.0.1 update urfave/cli v1.22.1, go-md2man v2.0.0, blackfriday v2.0.1 Jul 2, 2020
@thaJeztah thaJeztah marked this pull request as ready for review July 2, 2020 08:20
@thaJeztah
Copy link
Member Author

Updated this to use urfave/cli v1.22.1, and moved it out of draft

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 2, 2020

Build succeeded.

vendor.conf Outdated Show resolved Hide resolved
This updates urfave/cli and its dependencies to v1.22.1:

- diff for urfave/cli: urfave/cli@v1.22.0...v1.22.1
- diff for go-md2man: cpuguy83/go-md2man@v1.0.10...v2.0.0
- diff for blackfriday: russross/blackfriday@v1.5.2...v2.0.1

Also adds github.com/shurcooL/sanitized_anchor_name as a new dependency, which is
used by russross/blackfriday, but will be removed again in a future update (dependency
is already removed on the v2 branch through russross/blackfriday@919b1f5

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 2, 2020

Build succeeded.

@fuweid
Copy link
Member

fuweid commented Jul 2, 2020

do we need this urfave/cli#1092 ?

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit c91c72c into containerd:master Jul 2, 2020
@fuweid
Copy link
Member

fuweid commented Jul 2, 2020

Thanks @thaJeztah !

@thaJeztah thaJeztah deleted the md2manv2_urfave_bump branch July 2, 2020 09:25
@thaJeztah
Copy link
Member Author

do we need this urfave/cli#1092 ?

Temporarily went back to v1.22.1. I need to dive into urfave/cli#1092 again, there was a request to make it less "strict", will try to work on that today so that we can update to v1.22.5 if that's released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants