New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update urfave/cli v1.22.1, go-md2man v2.0.0, blackfriday v2.0.1 #4239
Conversation
Build succeeded.
|
vendor.conf
Outdated
github.com/sirupsen/logrus 60c74ad9be0d874af0ab0daef6ab07c5c5911f0d # v1.6.0 | ||
github.com/syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2 | ||
github.com/urfave/cli bfe2e925cfb6d44b40ad3a779165ea7e8aff9212 # v1.22.0 | ||
github.com/urfave/cli 053ba9dd02d2bfb768da2c1c50370c59d41dc04b # v1.22.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get somebody to fix urfave/cli#1092
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, dang. I read that issue, but forgot about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was trying to get the other dependencies updated to the v2
variants to be in line with moby and docker cli 😅
moving to "draft", pending urfave/cli#1092 to be merged and released |
The pending PR: urfave/cli#1135 |
abef5bb
to
b47a18e
Compare
b47a18e
to
9095eb9
Compare
Updated this to use urfave/cli v1.22.1, and moved it out of draft |
Build succeeded.
|
This updates urfave/cli and its dependencies to v1.22.1: - diff for urfave/cli: urfave/cli@v1.22.0...v1.22.1 - diff for go-md2man: cpuguy83/go-md2man@v1.0.10...v2.0.0 - diff for blackfriday: russross/blackfriday@v1.5.2...v2.0.1 Also adds github.com/shurcooL/sanitized_anchor_name as a new dependency, which is used by russross/blackfriday, but will be removed again in a future update (dependency is already removed on the v2 branch through russross/blackfriday@919b1f5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9095eb9
to
a6dd1f2
Compare
Build succeeded.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @thaJeztah ! |
Temporarily went back to v1.22.1. I need to dive into urfave/cli#1092 again, there was a request to make it less "strict", will try to work on that today so that we can update to v1.22.5 if that's released |
This updates urfave/cli and its dependencies to v1.22.1:
Also adds github.com/shurcooL/sanitized_anchor_name as a new dependency, which is
used by russross/blackfriday, but will be removed again in a future update (dependency
is already removed on the v2 branch through russross/blackfriday@919b1f5