Bump to Go 1.11.0

[thaJeztah]

Already saw some breakage in moby/moby#37358, so lets run it here as well

Changelog: https://tip.golang.org/doc/go1.11

[thaJeztah]

Opened a ticket upstream for the gofmt change; golang/go#26228

[thaJeztah]

temporarily cherry-picked #2420 to fix compilation on 1.11

[thaJeztah]

Okay, we're getting closer; 3 out of four pass (on Linux);

There's a panic on Go 1.11beta1 with CGO_ENABLED=1; https://api.travis-ci.org/v3/job/400360537/log.txt

?   	github.com/containerd/containerd/cmd/containerd-shim	1.013s	coverage: 9.3% of statements [no test files]
panic: invalid argument

goroutine 1 [running]:
github.com/containerd/containerd/cmd/containerd-stress.init.0()
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-stress/main.go:61 +0x73c
FAIL	github.com/containerd/containerd/cmd/containerd-stress	0.024s
make: *** [coverage] Error 1

Panic is done here;

containerd/cmd/containerd-stress/main.go

Lines 59 to 62 in c3971b1

	// set higher ulimits
	if err := setRlimit(); err != nil {
	panic(err)
	}

Originating from

containerd/cmd/containerd-stress/rlimit_unix.go

Lines 25 to 40 in c3971b1

	func setRlimit() error {
	rlimit := uint64(100000)
	if rlimit > 0 {
	var limit syscall.Rlimit
	if err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &limit); err != nil {
	return err
	}
	if limit.Cur < rlimit {
	limit.Cur = rlimit
	if err := syscall.Setrlimit(syscall.RLIMIT_NOFILE, &limit); err != nil {
	return err
	}
	}
	}
	return nil
	}

[mlaventure]

syscall.Setrlimit(...) is the most likely culprit, they may have been a breaking change in the go code.

[mlaventure]

Just checked, no changes to those syscalls. May be a regression in CGO, may want to print the value returned by Getrlimit() to ensure it's not corrupted somehow

[thaJeztah]

Failure on Windows; looks like there were some more format errors;

?   	github.com/containerd/containerd/version	[no test files]
# github.com/containerd/containerd/windows
windows\process.go:124: Wrapf format %s has arg s of wrong type github.com/containerd/containerd/runtime.Status
windows\task.go:287: Wrapf format %d has arg id of wrong type string
windows\task.go:300: Wrapf format %d has arg t.id of wrong type string
Makefile:223: recipe for target 'coverage' failed
mingw32-make: *** [coverage] Error 2

[thaJeztah]

Pushed a commit here, and as a separate PR; #2487

[codecov-io]

Codecov Report

Merging #2435 into master will increase coverage by 1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   43.74%   44.76%   +1.01%     
==========================================
  Files         100       93       -7     
  Lines       10728     9555    -1173     
==========================================
- Hits         4693     4277     -416     
+ Misses       5305     4585     -720     
+ Partials      730      693      -37

Flag	Coverage Δ
#linux	48.98% <ø> (+1.56%)	⬆️
#windows	41.04% <ø> (+0.13%)	⬆️

Impacted Files	Coverage Δ
mount/lookup_unix.go	0% <0%> (-75%)	⬇️
oci/spec.go	40% <0%> (-53.72%)	⬇️
mount/mount_linux.go	0% <0%> (-31.02%)	⬇️
archive/compression/compression.go	43.93% <0%> (-14.76%)	⬇️
mount/mountinfo_linux.go	53.06% <0%> (-8.17%)	⬇️
content/local/writer.go	52.63% <0%> (-5.22%)	⬇️
metadata/content.go	39.32% <0%> (-4.49%)	⬇️
metadata/leases.go	40.6% <0%> (-3.68%)	⬇️
metadata/migrations.go	42.3% <0%> (-1.45%)	⬇️
archive/tar.go	43.11% <0%> (-0.03%)	⬇️
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c444666...07237e3. Read the comment docs.

[thaJeztah]

Yay! All green now!

Let me rebase to get rid of the extra commit

[crosbymichael]

Why would we bump to a beta version?

[thaJeztah]

@crosbymichael sorry, probably should've kept the [do not merge]; mainly opening this to catch possible regressions before it leaves "beta"

[thaJeztah]

This needs to be changed to 1.11.x once the first patch release for Go 1.11 is released

[estesp]

Can you update this now? Now that 1.2 is out I think if you change this to 1.11.x we can merge this.

[thaJeztah]

Go 1.11 was released, so this is now no longer "WIP"

[crosbymichael]

LGTM

[dmcgowan]

Any reason or risk to changing this before 1.2? My preference would be to leave this open to test but merge after 1.2.0-rc.0.

[thaJeztah]

@estesp rebased and updated; thanks for the ping 👍

[estesp]

LGTM