Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document usage and design of blockfile snapshotter #10138

Merged
merged 1 commit into from May 1, 2024

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Apr 26, 2024

Based on this Slack discussion thread, I captured how to use the block file snapshotted, what its use case is, and how it works.

I am fairly certain that there are errors in here, but if we can capture this here and correct it, it will be known for future users and contributors, and might save people from having to answer the same questions over again on Slack 😄

Input to this is based on insights from @fuweid @samuelkarp @dcantah

There are 2 or 3 TODO comments here, where I either had open questions or was missing something. Help appreciate there.

@k8s-ci-robot
Copy link

Hi @deitch. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deitch deitch marked this pull request as draft April 26, 2024 08:46
@deitch deitch force-pushed the document-blockfile-snapshotter branch 2 times, most recently from 2505e4b to e82fa72 Compare April 26, 2024 08:49
docs/snapshotters/blockfile.md Outdated Show resolved Hide resolved
docs/snapshotters/blockfile.md Outdated Show resolved Hide resolved
@dcantah
Copy link
Member

dcantah commented Apr 26, 2024

Left some comments to start, thanks for this!!

@deitch deitch force-pushed the document-blockfile-snapshotter branch from e82fa72 to 6e58402 Compare April 26, 2024 08:58
@deitch
Copy link
Contributor Author

deitch commented Apr 26, 2024

Addressed all of your comments and raised some questions.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch force-pushed the document-blockfile-snapshotter branch from 6e58402 to e07b63d Compare April 28, 2024 08:44
@deitch deitch marked this pull request as ready for review April 28, 2024 08:44
@deitch
Copy link
Contributor Author

deitch commented Apr 28, 2024

Filled in the TODO sections, removed the "Draft" status. I am sure there are errors, but it is ready to have them fixed.

@dmcgowan
Copy link
Member

dmcgowan commented Apr 30, 2024

Looks good, in the last section it could be mentioned that if the underlying filesystem supports reflink (such as btrfs, xfs, apfs) then the layer copy is similarly as efficient storage wise as other snapshotters which support copy on write snapshotters. To consider as a follow up or if something else wants to play around with some examples there.

@dmcgowan dmcgowan added this pull request to the merge queue Apr 30, 2024
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixups, LGTM!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@dmcgowan dmcgowan added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@deitch
Copy link
Contributor Author

deitch commented May 1, 2024

I am not sure why the tests failed (and it blocked the merge). The entire PR is a document changes. 🤷‍♂️

@AkihiroSuda AkihiroSuda added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@AkihiroSuda AkihiroSuda added this pull request to the merge queue May 1, 2024
Merged via the queue into containerd:main with commit d9a58a8 May 1, 2024
45 checks passed
@deitch deitch deleted the document-blockfile-snapshotter branch May 1, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants