New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document usage and design of blockfile snapshotter #10138
document usage and design of blockfile snapshotter #10138
Conversation
Hi @deitch. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2505e4b
to
e82fa72
Compare
Left some comments to start, thanks for this!! |
e82fa72
to
6e58402
Compare
Addressed all of your comments and raised some questions. |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
6e58402
to
e07b63d
Compare
Filled in the |
Looks good, in the last section it could be mentioned that if the underlying filesystem supports reflink (such as btrfs, xfs, apfs) then the layer copy is similarly as efficient storage wise as other snapshotters which support copy on write snapshotters. To consider as a follow up or if something else wants to play around with some examples there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fixups, LGTM!
I am not sure why the tests failed (and it blocked the merge). The entire PR is a document changes. 🤷♂️ |
Based on this Slack discussion thread, I captured how to use the block file snapshotted, what its use case is, and how it works.
I am fairly certain that there are errors in here, but if we can capture this here and correct it, it will be known for future users and contributors, and might save people from having to answer the same questions over again on Slack 😄
Input to this is based on insights from @fuweid @samuelkarp @dcantah
There are 2 or 3
TODO
comments here, where I either had open questions or was missing something. Help appreciate there.