go.mod: go 1.22 #10110
go.mod: go 1.22 #10110
Conversation
AkihiroSuda
force-pushed
the
go-mod-1.22
branch
from
99d4651
to
097fdbf
Compare
AkihiroSuda
force-pushed
the
go-mod-1.22
branch
from
097fdbf
to
d734cdf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
go-mod-1.22
branch
2 times, most recently
from
be245e6
to
846595d
Compare
|
😞 this is becoming more and more disruptive for k8s to enforce "only latest" go versions supported. |
AkihiroSuda
force-pushed
the
go-mod-1.22
branch
from
846595d
to
ce74ac8
Compare
cc @dims Do you think this is negotiable on Kubernetes side? Do we need a KEP? |
|
For v2, it's probably ok to move towards go1.22; mostly looking that we've had this situation before, and I know that for containerd itself, we try to follow Go's recommendations to support "latest" and 'latest -1" at least to allow consumers of the module to transition. (We tried keeping compatibility with versions older than that, but that has become more problematic / difficult to maintain, also with go.mod now having changed the go version from a "recommendation", to enforced version) |
|
@thaJeztah @AkihiroSuda please chime in on kubernetes/kubernetes#123744 and if necessary golang/go#65573 TL;DR we are trying to work with the golang team to make it better, but will have to wait for golang 1.23 |
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
go-mod-1.22
branch
2 times, most recently
from
f6f7950
to
ebdae67
Compare
There was a problem hiding this comment.
nit: one minor change on the build docs. https://github.com/containerd/containerd/blame/main/BUILDING.md#L28. Need to update it to go1.22
runc is incompatible with Go 1.22 on glibc-based distros (opencontainers/runc issue 4233) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Depended by k8s.io/cri-api >= v0.30.0 (Kubernetes v1.30, PR 10019) https://github.com/kubernetes/cri-api/blob/v0.30.0/go.mod#L5 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
go-mod-1.22
branch
from
ebdae67
to
1578288
Compare
Thanks, updated |
| @@ -1,6 +1,6 @@ | |||
| module github.com/containerd/containerd/v2 | |||
|
|
|||
| go 1.21 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
(Not sure whether this should be 1.22.2 or just 1.22.0)
There was a problem hiding this comment.
If we upgrade to 1.22.2, it will force anyone using containerd module to be upgraded to 1.22.2. I am good with keeping at 1.22.0
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Depended by k8s.io/cri-api >= v0.30.0 (Kubernetes v1.30)
https://github.com/kubernetes/cri-api/blob/v0.30.0/go.mod#L5