Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow split configurations by default: import conf/*.toml by default. #10061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Romain-Geissler-1A
Copy link

Distro vendor might want to customize their containerd configuration and might prefer to split it in multiple files. Usually this is done with a /etc/tool.d/*.conf scheme (for example /etc/sysctl.d). This would allow distro to put any toml file in /etc/containerd/conf in Linux to customize the default configuration.

@k8s-ci-robot
Copy link

Hi @Romain-Geissler-1A. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Romain-Geissler-1A Romain-Geissler-1A force-pushed the allow-split-configuration-by-default branch from bfba931 to af5162f Compare April 10, 2024 16:39
Distro vendor might want to customize their containerd configuration
and might prefer to split it in multiple files. Usually this is done
with a /etc/tool.d/*.conf scheme (for example /etc/sysctl.d). This would
allow distro to put any toml file in /etc/containerd/conf in Linux to
customize the default configuration.

Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
@Romain-Geissler-1A Romain-Geissler-1A force-pushed the allow-split-configuration-by-default branch from af5162f to f09ba60 Compare April 10, 2024 16:45
@kzys
Copy link
Member

kzys commented Apr 24, 2024

Hmm, Linux distributions can have its own /etc/contaiainerd/config.toml. Do you know distros that need this change?

@Romain-Geissler-1A
Copy link
Author

Romain-Geissler-1A commented Apr 24, 2024

Distros no, but I know in my own company this is something we would like to have. Most software I know do accept a "software.conf.d" default directory where config file can be dropped and included automatically, and this allows companies/site specific config to be easily distributed via various way and be taken into account. The problem with a single config file is that usually this config file is distributed by the distro, and thus any form of customization becomes a maintenance burden as you have to constantely keep up with the distro update, and this because much more a problem when inside the same organisation you support N distro/distro version. With standalone separate config file which are auto-loaded the distribution and maintenance is easier.

@Romain-Geissler-1A
Copy link
Author

One real world use case I have is configuring kind which right now doesn't default to using version 2 mirror configuration, via a separate file rather than via a kind containerd config patch which affects the global configuration. In our organization like in many others we shall access docker registry via internal mirrors rather than directly targetting the reigstries via internet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants