Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/cri: log ctr's exit event on info level #10026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ningmingxiao
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Apr 1, 2024

sometimes I want to know when container is exited,but default log level is info will not print exited events
some issue:#10025

Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
@ningmingxiao ningmingxiao changed the title add info of exit event add info of exited event Apr 1, 2024
@ktock
Copy link
Member

ktock commented Apr 3, 2024

Why not --log-level debug?

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Apr 3, 2024

Why not --log-level debug?
--log-level debug will generate many logs and it is easy to cause logroate, many of them are not important.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's acceptable to me.

@fuweid fuweid changed the title add info of exited event internal/cri: log ctr's exit event on info level Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants