Skip to content

Commit

Permalink
Do not use go get to install executables
Browse files Browse the repository at this point in the history
https://go.dev/doc/go-get-install-deprecation

Based on commit 6b0e241, but modified
to apply to the 1.4 branch.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  • Loading branch information
kzys authored and thaJeztah committed Feb 15, 2022
1 parent b907c24 commit d6d073b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
3 changes: 2 additions & 1 deletion script/setup/install-critools
Expand Up @@ -20,7 +20,8 @@
#
set -eu -o pipefail

go get -u github.com/onsi/ginkgo/ginkgo
GO111MODULE=on go install github.com/onsi/ginkgo/ginkgo@v1.16.5

CRITEST_COMMIT=53ad8bb7f97e1b1d1c0c0634e43a3c2b8b07b718
git clone https://github.com/kubernetes-sigs/cri-tools.git "$GOPATH"/src/github.com/kubernetes-sigs/cri-tools
cd "$GOPATH"/src/github.com/kubernetes-sigs/cri-tools
Expand Down
10 changes: 4 additions & 6 deletions script/setup/install-dev-tools
Expand Up @@ -20,15 +20,13 @@
#
set -eu -o pipefail

# install the `protobuild` binary in $GOPATH/bin; requires module-aware install
# to pin dependencies
GO111MODULE=on go get github.com/stevvooe/protobuild
# install `protobuild` and other commands
GO111MODULE=on go install github.com/stevvooe/protobuild@v0.1.0
GO111MODULE=on go install github.com/cpuguy83/go-md2man/v2@v2.0.0
GO111MODULE=on go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.23.8

# the following packages need to exist in $GOPATH so we can't use
# go modules-aware mode of `go get` for these includes used during
# proto building
GO111MODULE=off go get -d github.com/gogo/googleapis || true
GO111MODULE=off go get -d github.com/gogo/protobuf || true

GO111MODULE=on go get github.com/cpuguy83/go-md2man/v2@v2.0.0
GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.23.8

0 comments on commit d6d073b

Please sign in to comment.