toil(pkg-mgr:pip): report SBOM "cachi2:missing_hash:in_file" property... #531
+294
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-alkov
force-pushed
the
toil-pkg-mgr-pip-fix-SBOM-missing-hash
branch
2 times, most recently
from
f3c2b1c
to
b160f5c
Compare
ben-alkov
requested review from
brunoapimentel,
eskultety,
taylormadore,
ejegrova and
slimreaper35
|
Ignore, this is obviated by later work. |
ben-alkov
force-pushed
the
toil-pkg-mgr-pip-fix-SBOM-missing-hash
branch
5 times, most recently
from
83ea150
to
445010c
Compare
ben-alkov
force-pushed
the
toil-pkg-mgr-pip-fix-SBOM-missing-hash
branch
3 times, most recently
from
9cd7c0b
to
b79b4fc
Compare
...for checking URL download's "insecure" and "url_with_hash" properties is incorrect, strictly speaking Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
- rename `.*verif[y|ied]` -> `.*match[ed]` to more accurately reflect usage - in many places, we say "hash" when we mean "checksum", strictly speaking Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
- all download_infos should have the same field order Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
…cies... ...to make it easier to understand Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
...when *any* 'requirements*.txt' file is unhashed - adjust unit tests Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
ben-alkov
force-pushed
the
toil-pkg-mgr-pip-fix-SBOM-missing-hash
branch
from
b79b4fc
to
8360891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when any 'requirements*.txt file is unhashed
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)