auth: Use retries when querying for token #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
commented
Jun 22, 2020
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
MartinBasti
reviewed
Jun 22, 2020
* CLOUDBLD-1292 Move get_retrying_requests_session() out of util and into its own module to avoid a cyclic import between auth and util. Use a retrying session when querying for token in HTTPBearerAuth. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
force-pushed
the
retry-get-token
branch
from
8dd0a82
to
f030d2b
Compare
chmeliik
requested review from
MartinBasti,
rcerven,
athos-ribeiro,
ben-alkov and
tkdchen
rcerven
approved these changes
Jun 23, 2020
MartinBasti
approved these changes
Jun 23, 2020
|
Release notes: Registry authentication will use retries when querying for bearer token (probably not needed 'cause it's a minor change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move get_retrying_requests_session() out of util and into its own module
to avoid a cyclic import between auth and util.
Use a retrying session when querying for token in HTTPBearerAuth.
Signed-off-by: Adam Cmiel acmiel@redhat.com
Maintainers will complete the following section