Add note to Volume Lifecycle figure #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-1
…On Tue, Jun 14, 2022 at 11:55 PM Yuiko Mouri ***@***.***> wrote:
This PR adds note to Volume Lifecycle figure in spec.md in order to
explain actual Kubernetes volume lifecycle behavior which has changed by
non-graceful node shutdown feature of Kubernetes .
Fix: #512 <#512>
------------------------------
You can view, comment on, or merge this pull request online at:
#513
Commit Summary
- 88dd4ed
<88dd4ed>
Add note to Volume Lifecycle figure
File Changes
(1 file
<https://github.com/container-storage-interface/spec/pull/513/files>)
- *M* spec.md
<https://github.com/container-storage-interface/spec/pull/513/files#diff-bc6661da34ecae62fbe724bb93fd69b91a7f81143f2683a81163231de7e3b545>
(1)
Patch Links:
- https://github.com/container-storage-interface/spec/pull/513.patch
- https://github.com/container-storage-interface/spec/pull/513.diff
—
Reply to this email directly, view it on GitHub
<#513>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KLEYRHWHKKF6DBTPMWLVPFH4NANCNFSM5YZZVH4A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
James DeFelice
|
xing-yang
reviewed
Jun 21, 2022
| @@ -210,6 +210,7 @@ creation to destruction. | |||
| Figure 6: The lifecycle of a dynamically provisioned volume, from | |||
| creation to destruction, when the Node Plugin advertises the | |||
| STAGE_UNSTAGE_VOLUME capability. | |||
| NOTE: When using Non-Graceful Node Shutdown feature in Kubernetes, status can be moved from PUBLISHED to CREATED without going through VOL_READY and/or NODE_READY status. | |||
There was a problem hiding this comment.
This behavior is not introduced by Non-Graceful Node Shutdown feature. Kubernetes already supports this behavior without Non-Graceful Node Shutdown. See "Test 2" in the PR description section below. By forcefully deleting the Pods on the shutdown node manually, Kubernetes will behave this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds note to Volume Lifecycle figure in
spec.mdin order to explain actual Kubernetes volume lifecycle behavior which has changed by non-graceful node shutdown feature of Kubernetes .Fix: #512