New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current position for calculating finished progress bar per_sec instead of bar length #605

Merged

djc merged 1 commit into console-rs:main from DanGonite57:abandon_persec

Jan 4, 2024

Contributor

DanGonite57 commented Nov 20, 2023

Fixes #601


          Use pos for finished progress bar per_sec instead of len

d52c9c7

djc approved these changes

View reviewed changes

Collaborator

djc left a comment

Sorry for the long delay in reviewing this -- I think it makes sense.

For future robustness, please consider submitting another PR that includes a test for this.

djc merged commit 2a8b2ea into console-rs:main

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment