added LogWrapper to bridge indicatif and the log crate #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I'm not sure this belongs in indicatif. I think I'd rather see it as a separate crate, e.g. like the other loggers: https://docs.rs/log/latest/log/#available-logging-implementations. I don't have strong feelings though, so I could be convinced otherwise. |
|
I agree. Would be happy to link to it from the README/documentation, though. |
|
yeah i agree, did it here: https://crates.io/crates/indicatif-log-bridge |
Awesome, thanks! Feel free to submit a PR that edits the README to mention the crate. |
|
allright i will, but first i gotta polish/add a bit of documentation to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a much nicer solution than #566 and #567 in my opinion.
this is behind the "log" feature for now.
we could consider making this a default feature, it barely adds any code, does add the log crate as dependency though.