Add missing space before unit #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
This seems good for consistency if nothing else. @chris-laplante, what do you think?
Makes sense to me. |
|
Thanks, @Error-42 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm new to contributing, please be pedantic (but not opinionated) about the way I contribute.)
The storage unit without prefix (B, but not KB, KiB...) is not separated from the number by a space, which is incorrect (see 5.3.3 here) and inconsistent with the formatting of prefixed units (KB, KiB...) in this library.
This is a breaking change and requires the modification of one test.