feat: add futures::Stream support #551

aatifsyed · 2023-06-22T20:34:21Z

I've mostly just copied the existing patterns for iterator and asyncread

djc

I think this is a good idea, but the implementation needs some work.

examples/stream.rs

Cargo.toml

src/iter.rs

src/progress_bar.rs

djc

Thanks, this looks much better!

Cargo.toml

src/progress_bar.rs

This reverts commit 5058d9c.

djc reviewed Jun 23, 2023

View reviewed changes

examples/stream.rs Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

src/iter.rs Outdated Show resolved Hide resolved

src/progress_bar.rs Outdated Show resolved Hide resolved

feat: add futures::Stream support

26b0ec6

aatifsyed requested a review from djc June 29, 2023 23:27

djc approved these changes Jun 30, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

src/progress_bar.rs Show resolved Hide resolved

aatifsyed added 4 commits June 30, 2023 11:03

feat: implicit impl futures_core::Stream in arg and return

5058d9c

fix: better doctest

50e8d13

Revert "feat: implicit impl futures_core::Stream in arg and return"

37a4314

This reverts commit 5058d9c.

doc: why we have futures as a dev-dependency

2336440

aatifsyed requested a review from djc June 30, 2023 10:28

djc approved these changes Jun 30, 2023

View reviewed changes

djc merged commit 1cbfe20 into console-rs:main Jun 30, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add futures::Stream support #551

feat: add futures::Stream support #551

aatifsyed commented Jun 22, 2023 •

edited

djc left a comment

djc left a comment

feat: add futures::Stream support #551

feat: add futures::Stream support #551

Conversation

aatifsyed commented Jun 22, 2023 • edited

djc left a comment

Choose a reason for hiding this comment

djc left a comment

Choose a reason for hiding this comment

aatifsyed commented Jun 22, 2023 •

edited