Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention the prefix and message placeholders in the with_ docs #529

Merged
merged 1 commit into from Apr 7, 2023
Merged

Mention the prefix and message placeholders in the with_ docs #529

merged 1 commit into from Apr 7, 2023

Conversation

lnicola
Copy link
Contributor

@lnicola lnicola commented Apr 7, 2023

Closes #528

djc
djc approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chris-laplante chris-laplante merged commit 4987fc5 into console-rs:main Apr 7, 2023
9 checks passed
@lnicola lnicola deleted the pb-docs-placeholders branch April 7, 2023 16:50
@djc djc mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProgressBar::with_message does nothing?
3 participants
@lnicola @djc @chris-laplante