Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiProgress println when having no bars #518

Closed
wants to merge 2 commits into from

Conversation

Ekleog
Copy link

@Ekleog Ekleog commented Feb 6, 2023

Fixes #447

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@chris-laplante chris-laplante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Sorry for the delay in review.

@djc
Copy link
Collaborator

djc commented Aug 1, 2023

@Ekleog did you want to rebase this/fix up CI?

@Ekleog
Copy link
Author

Ekleog commented Dec 16, 2023

@djc TBH I need it only for a pet project that I have basically not touched in a year; and considering the review took long enough for the code to bitrot I'm not going to spend more time on this until I need it again.

That said, feel free to take the code in this PR and push it past the finish line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiProgress:println doesn't behave correctly when no progress bars have been added yet
3 participants