Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky render test by dropping old spinners #463

Closed
wants to merge 1 commit into from
Closed

fix flaky render test by dropping old spinners #463

wants to merge 1 commit into from

Commits on Aug 10, 2022

  1. fix flaky render test by dropping old spinners 

    Before this change, the ticker_drop render test was occasionally
flaky.

Reproduce it by running this command:

    while cargo test --all-features ticker_drop; do :; done

It will eventually fail with something like this:

===========
running 1 test
test ticker_drop ... FAILED

failures:

---- ticker_drop stdout ----
thread 'ticker_drop' panicked at 'assertion failed: `(left == right)`
  left: `"⠁ doing stuff 0\n  doing stuff 1\n  doing stuff 2\n  doing stuff 3\n  doing stuff 4"`,
 right: `"  doing stuff 0\n  doing stuff 1\n  doing stuff 2\n  doing stuff 3\n  doing stuff 4"`', tests/render.rs:347:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
===========

Somehow the spinner is not correctly getting finished. Clearly there is
a subtle race condition somewhere but I haven't been able to track it
down.
    @chris-laplante
    chris-laplante committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    5e6716e View commit details
    Browse the repository at this point in the history