Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework zombie handling to fix #451 and #464 #460

Merged
merged 5 commits into from Sep 13, 2022
Merged

Rework zombie handling to fix #451 and #464 #460

merged 5 commits into from Sep 13, 2022

Commits on Sep 8, 2022

  1. No-op MultiState::draw if we are panicking

    @chris-laplante
    chris-laplante committed Sep 8, 2022
    Copy the full SHA
    a19269e View commit details
    Browse the repository at this point in the history

  2. clarify comment for MultiState::orphan_lines member

    @chris-laplante
    chris-laplante committed Sep 8, 2022
    Copy the full SHA
    3833a70 View commit details
    Browse the repository at this point in the history

  3. rewrite zombie handling 

    Fixes console-rs#464 and console-rs#451

Possibly fixes console-rs#411 (if not already fixed?)
    @chris-laplante
    chris-laplante committed Sep 8, 2022
    Copy the full SHA
    4f20824 View commit details
    Browse the repository at this point in the history

  4. modify render tests to account for fixed MultiProgress::println/clear… 

    … behavior

Specifically, `clear` no longer clears lines printed by `println`. Also,
changed some render tests to not manually reset the in-memory terminal
since then it gets out of sync with MultiProgress.
    @chris-laplante
    chris-laplante committed Sep 8, 2022
    Copy the full SHA
    88e288e View commit details
    Browse the repository at this point in the history

  5. add new render tests that exercise zombie handling

    @chris-laplante
    chris-laplante committed Sep 8, 2022
    Copy the full SHA
    c2f2c75 View commit details
    Browse the repository at this point in the history