Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressions #414

Merged
merged 3 commits into from Mar 21, 2022
Merged

Fix regressions #414

merged 3 commits into from Mar 21, 2022

Commits on Mar 21, 2022

  1. Replace ProgressBar's draw target after removing it from MultiProgress 

    While we previously removed the ProgressBar's state from the
MultiProgressState, we did not remove the remote draw target
from the bar's draw target, so that it could start to draw
into the MultiProgress state again in surprising ways.
    @djc
    djc committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    7c0ee52 View commit details
    Browse the repository at this point in the history

  2. Don't write to terminal while panicking 

    This might hide the panic output, making it extremely confusing
how the process might have ended.
    @djc
    djc committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4bcd612 View commit details
    Browse the repository at this point in the history

  3. Make sure with_style() and set_style() behave the same 

    In #395, we made it so that message and prefix are carried over
when calling ProgressBar::with_style(), but this did not change
ProgressBar::set_style(). Reuse the same logic by having
with_style() call set_style(), so that these cannot fall out of
sync again.
    @djc
    djc committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4dfb8d4 View commit details
    Browse the repository at this point in the history