Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through stream_position in ProgressBarIter #309

Merged
merged 1 commit into from Sep 15, 2021
Merged

Pass through stream_position in ProgressBarIter #309

merged 1 commit into from Sep 15, 2021

Commits on Sep 11, 2021

  1. Pass through stream_position in ProgreessBarIter 

    This avoids sending a stream_position update and also preserves optimizations that the underlying object may have made for stream_position.

For example, when wrapping a `BufReader` object, adding this impl allows the use of `.stream_position()` in functions that take a generic `Seek` object without causing the performance drop associated with the default impl of `stream_position` calling `seek(SeekFrom::Current(0))` and throwing away the buffer each time.
    @rlee287
    rlee287 committed Sep 11, 2021
    Copy the full SHA
    1ab2525 View commit details
    Browse the repository at this point in the history