Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Remove MultiProgress::join() #231

Closed
wants to merge 3 commits into from
Closed

[RFC] Remove MultiProgress::join() #231

wants to merge 3 commits into from

Commits on Jan 3, 2021

  1. Remove MultiProgress::join() 

    Instead of drawing from a thread blocked on MultiProgress::join(), draw directly
from the threads updating the ProgressBars in the MultiProgress, using write
access to MultiProgress's state to synchronize terminal updates.
    @marienz
    marienz committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    08dbab9 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Remove MultiObject's done field 

    We set this from the "finished" field of a ProgressDrawState, which we also
store. It does not look like the separate field is necessary.
    @marienz
    marienz committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    38115c0 View commit details
    Browse the repository at this point in the history

  2. Remove MultiObject

    @marienz
    marienz committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    6c4285a View commit details
    Browse the repository at this point in the history