Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode awareness for progress_chars #174

Merged
merged 4 commits into from Jun 10, 2020
Merged

Unicode awareness for progress_chars #174

merged 4 commits into from Jun 10, 2020

Conversation

djugei
Copy link
Contributor

@djugei djugei commented May 24, 2020

previously using two-wide characters as progress chars made the bar overflow.

also aded a bit more unicode-awareness (grapheme-clusters instead of simple chars)

and made the spinner a bit more efficient (Box instead of String) as it never gets modified.

@mitsuhiko
Copy link
Collaborator

I like the idea but I will put this behind a feature flag to avoid adding dependencies.

@mitsuhiko mitsuhiko merged commit cbd0133 into console-rs:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants