Add vim mode to FuzzySelect
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration option to enable vim mode to `FuzzySelect`
pksunkara
reviewed
May 21, 2023
pksunkara
requested changes
May 21, 2023
- Rename `FuzzySelect::enable_vim_mode` to `FuzzySelect::vim_mode`. - Implement quitting in vim_mode. - Remove `vim_mode = false` when a character is entered.
pksunkara
reviewed
May 21, 2023
| @@ -209,6 +221,8 @@ impl FuzzySelect<'_> { | |||
|
|
|||
| term.hide_cursor()?; | |||
|
|
|||
| let mut vim_mode = false; | |||
There was a problem hiding this comment.
Shouldn't this default to enable_vim_mode?
There was a problem hiding this comment.
Probably not. enable_vim_mode is meant to fully disable vim mode; the vim_mode variable keeps track of when you are entering text or when vim bindings are used. Typically you'd fuzzy find first, then use vim mode, So I think it should always start with no vim mode.
Change the quit key to be 'q' instead of Escape.
pksunkara
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a vim mode to
FuzzySelect.Vim mode works as follows:
This is based on the vim mode from https://github.com/go-survey/survey.
To achieve this I've added the following changes:
vim_mode.vim_modeis true.FuzzySelect::enable_vim_modemethod.These changes have the following benefits:
I hope my contribution can be of use!