Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish CI #254

Merged
merged 4 commits into from Apr 15, 2023
Merged

Polish CI #254

merged 4 commits into from Apr 15, 2023

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Apr 15, 2023

  • The big item here is switching away from actions-rs since the entire organization is unmaintained and the actions are starting to fall apart.
  • The second item is switching the lint job from running with the MSRV to stable, so dialoguer doesn't miss out on newer lints.
  • The other two commits are just nits without any functional change.

See the individual commits for details.

@LingMan
Switch away from actions-rs
db6892b 
The actions-rs organization is unmaintained with the sole member being
unresponsive for two years.

The actions still use Node 12 and the `set-output` command, both of which are deprecated and will
be removed by Github Actions by Summer 2023. [1][2]

Switch from `actions-rs/toolchain` to `dtolnay/rust-toolchain` and from `actions-rs/cargo` to plain
cargo commands.

[1] https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
[2] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@LingMan
Use cargo check's --check option directly
a1e0f72
@LingMan
Drop duplicated clippy options
ba07951 
From the documentation of `--all-targets`:
  Check all targets. This is equivalent to specifying --lib --bins --tests --benches --examples.
@LingMan
Run the linting on stable rust
682164a 
Newer versions may have additional lints which would be missed by running MSRV Clippy.
@pksunkara
Copy link
Collaborator

Can you give me an example on where the actions are falling apart? One advantage of cargo action is that it comments the warnings and errors on GitHub.

@LingMan
Copy link
Contributor Author

LingMan commented Apr 15, 2023

Quoting from the relevant commit message:

The actions still use Node 12 and the set-output command, both of which are deprecated and will
be removed by Github Actions by Summer 2023. [1][2]
[...]
[1] https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
[2] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@pksunkara
Copy link
Collaborator

I think this needs rebase.

@LingMan
Copy link
Contributor Author

LingMan commented Apr 15, 2023 •
edited

Rebased. Am I assuming correctly that the other two comments you left about the examples and the tag have resolved themselves? Can't find them in the web UI and you approved the PR, so it looks like you deleted them.

@pksunkara pksunkara merged commit d77d5cd into console-rs:master Apr 15, 2023
10 of 14 checks passed
@LingMan LingMan deleted the ci branch April 15, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LingMan @pksunkara