Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle selection items overflowing several times #190

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Handle selection items overflowing several times #190

wants to merge 4 commits into from

Commits on May 5, 2022

  1. fix/refactor: rewrite size_vec collection code using iterators. 

    Handle multi-line items in sort and fuzzy_select.
Select and multi-select already handle these.
    @grunweg
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6cad8ae View commit details
    Browse the repository at this point in the history

  2. fix: handle very long items in clear_preserve_prompt correctly. 

    The previous code would (correctly) handle the case of an item
spanning between one and two lines, but failed to consider the case
of the output spanning more than two. Extend the logic to cover that.
    @grunweg
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    13f5631 View commit details
    Browse the repository at this point in the history

  3. doc: document and comment clear_preserve_prompt(). 

    Record the logic of the commit which introduced it.
The current logic is not quite correct; we'll fix that in the next commits.
    @grunweg
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    4039d45 View commit details
    Browse the repository at this point in the history

  4. fix: fix off-by-two errors when determining item width in selection p… 

    …rompts.

Formatting each item adds two additional characters,
which the code forgot to take into account.
    @grunweg
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    26dd942 View commit details
    Browse the repository at this point in the history