New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend and tweak documention in select.rs and theme.rs. #177
base: master
Are you sure you want to change the base?
Commits on Jan 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 332c49e - Browse repository at this point
Copy the full SHA 332c49eView commit details
Commits on Feb 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9c9ed0e - Browse repository at this point
Copy the full SHA 9c9ed0eView commit details -
doc: Use imperative tense in select.rs.
In addition, consistently speak of a 'selection prompt'.
Configuration menu - View commit details
-
Copy full SHA for 86ebe75 - Browse repository at this point
Copy the full SHA 86ebe75View commit details -
doc: Reword some doc comments in select.rs.
The comment on max_length was simply outdated.
Configuration menu - View commit details
-
Copy full SHA for 7426264 - Browse repository at this point
Copy the full SHA 7426264View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2cc7c5 - Browse repository at this point
Copy the full SHA c2cc7c5View commit details
Commits on May 5, 2022
-
Document some members in select.rs.
I'm not sure about the grammar or format of the comments, but open to changing it.
Configuration menu - View commit details
-
Copy full SHA for 0d28b43 - Browse repository at this point
Copy the full SHA 0d28b43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 684a08a - Browse repository at this point
Copy the full SHA 684a08aView commit details -
doc: copy-edit some doc comments in confirm.rs.
The comment of default() was misleading: if a default value is set, the user can still change the selected answer. They merely have the *additional* option of confirming the default choice.
Configuration menu - View commit details
-
Copy full SHA for cdbab55 - Browse repository at this point
Copy the full SHA cdbab55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13a2153 - Browse repository at this point
Copy the full SHA 13a2153View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1875fe5 - Browse repository at this point
Copy the full SHA 1875fe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 537fd91 - Browse repository at this point
Copy the full SHA 537fd91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 623acf8 - Browse repository at this point
Copy the full SHA 623acf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7827056 - Browse repository at this point
Copy the full SHA 7827056View commit details -
refactor: use prompts_reset_heights=true in password prompt.
Setting it to false doesn't make a difference in practice. The distinction between self.height and self.prompt_height only matters when calling TermThemeRenderer::clear_preserve_prompt(): that method preserves prompts and only clears input below the most recent prompt. However, the password prompt only calls TermThemeRenderer::clear(), which treats height and prompt_height in the same way. The function set_prompts_reset_height is now unused, hence is removed.
Configuration menu - View commit details
-
Copy full SHA for 497de38 - Browse repository at this point
Copy the full SHA 497de38View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1dfaa1 - Browse repository at this point
Copy the full SHA f1dfaa1View commit details
Commits on May 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cb1ae52 - Browse repository at this point
Copy the full SHA cb1ae52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14a70e1 - Browse repository at this point
Copy the full SHA 14a70e1View commit details