Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend and tweak documention in select.rs and theme.rs. #177

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Commits on Jan 20, 2022

  1. Two typo fixes.

    grunweg committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    332c49e View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Configuration menu
    Copy the full SHA
    9c9ed0e View commit details
    Browse the repository at this point in the history
  2. doc: Use imperative tense in select.rs.

    In addition, consistently speak of a 'selection prompt'.
    grunweg committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    86ebe75 View commit details
    Browse the repository at this point in the history
  3. doc: Reword some doc comments in select.rs.

    The comment on max_length was simply outdated.
    grunweg committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    7426264 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2cc7c5 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Document some members in select.rs.

    I'm not sure about the grammar or format of the comments, but open to changing it.
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    0d28b43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    684a08a View commit details
    Browse the repository at this point in the history
  3. doc: copy-edit some doc comments in confirm.rs.

    The comment of default() was misleading: if a default value is set,
    the user can still change the selected answer. They merely have the
    *additional* option of confirming the default choice.
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    cdbab55 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    13a2153 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1875fe5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    537fd91 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    623acf8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7827056 View commit details
    Browse the repository at this point in the history
  9. refactor: use prompts_reset_heights=true in password prompt.

    Setting it to false doesn't make a difference in practice.
    
    The distinction between self.height and self.prompt_height only matters
    when calling TermThemeRenderer::clear_preserve_prompt(): that method preserves
    prompts and only clears input below the most recent prompt.
    However, the password prompt only calls TermThemeRenderer::clear(),
    which treats height and prompt_height in the same way.
    
    The function set_prompts_reset_height is now unused, hence is removed.
    grunweg committed May 5, 2022
    Configuration menu
    Copy the full SHA
    497de38 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f1dfaa1 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Configuration menu
    Copy the full SHA
    cb1ae52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14a70e1 View commit details
    Browse the repository at this point in the history