Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overflow in completion example #169

Merged
merged 2 commits into from Feb 11, 2022
Merged

Fix buffer overflow in completion example #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1e9a5
Fix buffer overflow for completion example
bryanhitc Jan 26, 2022
e4ffea8
fix formatting and improve naming
bryanhitc Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions examples/completion.rs
View file
Open in desktop
Expand Up @@ -29,10 +29,14 @@ impl Default for MyCompletion {
impl Completion for MyCompletion {
/// Simple completion implementation based on substring
fn get(&self, input: &str) -> Option<String> {
let s = input.to_string();
let ss: Vec<&String> = self.options.iter().filter(|x| s == x[..s.len()]).collect();
if ss.len() == 1 {
Some(ss[0].to_string())
let matches = self
.options
.iter()
.filter(|option| option.starts_with(input))
.collect::<Vec<_>>();
bryanhitc marked this conversation as resolved.
Show resolved Hide resolved

if matches.len() == 1 {
Some(matches[0].to_string())
} else {
None
}
Expand Down