Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alternate screen (fixes #63) #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

alternate screen (fixes #63) #65

wants to merge 2 commits into from

Conversation

aeosynth
Copy link

Please review.

@aeosynth
Copy link
Author

aeosynth commented May 20, 2020 •
edited

ok I don't know what the (legacy?) windows api for alternate screen is. the added functions in windows_term.rs don't handle the case where out.is_msys_tty is false.

@pksunkara pksunkara linked an issue May 20, 2020 that may be closed by this pull request
alternate screen #63
Open
@pksunkara
Copy link
Collaborator

Looks good. You can use the following to do it in windows.

https://docs.microsoft.com/en-us/windows/console/createconsolescreenbuffer
https://docs.microsoft.com/en-us/windows/console/createconsolescreenbuffer

Check the example here, https://docs.microsoft.com/en-us/windows/console/reading-and-writing-blocks-of-characters-and-attributes

@pksunkara
Copy link
Collaborator

@aeosynth Any update on this?

Archina pushed a commit to Archina/console that referenced this pull request Apr 5, 2021
@pksunkara
Merge pull request console-rs#65 from MichaelAquilina/fix/crash_divid…
1202848 
…e_by_zero
dtolnay pushed a commit to dtolnay-contrib/console that referenced this pull request Feb 4, 2022
@seanmonstar
console: set task poll percentile constraint to exactly 24 (console-r…
fb08d02 
…s#65)

With it only having a "max" of 24, if the chart needed to take up more
space, it would use up all of it and the percentile window would be
gone.
@rljacobson
Copy link

Do I understand correctly that the only thing missing from this PR is support for legacy Windows terminals?

@mitsuhiko
Copy link
Collaborator

For what it's worth if it works on any windows terminal that's probably good enough if sufficient documentation is added. If you can make mergeable and add documentation it should be fine to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alternate screen
4 participants
@aeosynth @pksunkara @rljacobson @mitsuhiko