Add logger trait #93
Merged
Add logger trait #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new `Logger` trait which can be used to access all log events emitted during compilation. Currently these only include messages emitted by the `@debug` and `@warn` statements. Changes were implemented in a backwards-compatible manner, but the current `Options::quiet` method has been marked as deprecated, as its behavior can be achieved using the `NullLogger` structure. The default logger used is `StdLogger` which writes all log events to standard error. This reflect the default behavior prior to introduction of `Logger`. With these new changes, it is also now possible to properly test the `@debug` and `@warn` statements.
|
thanks, i really like this change! |
|
This has been published to crates.io as part of version 0.13.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new
Loggertrait which can be used to access all log events emitted during compilation. Currently these only include messages emitted by the@debugand@warnstatements.Changes were implemented in a backwards-compatible manner, but the current
Options::quietmethod has been marked as deprecated, as its behavior can be achieved using theNullLoggerstructure. The default logger used isStdLoggerwhich writes all log events to standard error. This reflect the default behavior prior to introduction ofLogger.With these new changes, it is also now possible to properly test the
@debugand@warnstatements.