Fix @forward
statement altering the scope of the forwarded module
#85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the @forward statement multiple times on the same module, there was an unintended mutation of the loaded module scope. Using
@forward "path" as prefix-*;
would change the scope for a module loaded without a prefix too or with a different prefix, resulting in errors such as "Undefined mixin" or "Undefined function".I initially found the issue while trying to compile Carbon Design System SCSS style with grass.
The scope built for a particular forward statement in now directly included on the
ForwardedModule
type just like how its done for theShadowedModule
type.